[Webkit-unassigned] [Bug 21930] Add MediaPlayerPrivateChromium to MediaPlayer

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=21930


darin at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24750|review?                     |review+
               Flag|                            |




------- Comment #7 from darin at apple.com  2008-10-29 13:01 PDT -------
(From update of attachment 24750)
> Index: ChangeLog
> ===================================================================
> --- ChangeLog	(revision 37973)
> +++ ChangeLog	(working copy)
> @@ -1,3 +1,12 @@
> +2008-10-29  Andrew Scherkus  <scherkus at chromium.org>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        Add MediaPlayerPrivate header include for Chromium platform.
> +
> +        * WebCore\platform\graphics\MediaPlayer.cpp
> +:
> +

I'm not sure how you're generating ChangeLog files but there are three problems
with this one:

    1) The path uses \ rather than / -- we use / in our ChangeLog even though
Windows is one of the platforms we support.
    2) The colon is on a separate line after the filename.
    3) Doesn't contain a link to this bug on bugs.webkit.org; we prefer to do
that.

The person who lands this patch will need to fix these problems.

r=me


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.