[Webkit-unassigned] [Bug 21949] New: No need to clobber all ResourceRequest fields in FrameLoader::reload()

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 29 11:35:24 PDT 2008


https://bugs.webkit.org/show_bug.cgi?id=21949

           Summary: No need to clobber all ResourceRequest fields in
                    FrameLoader::reload()
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Page Loading
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: darin at chromium.org


No need to clobber all ResourceRequest fields in FrameLoader::reload()

Presently, FrameLoader::reload clobbers all fields of the initialRequest when
there is an unreachableURL associated with the current DocumentLoader.  This
causes problems for the Chromium port since we store some extra data on the
ResourceRequest object that we need to have preserved across a
FrameLoader::reload call.

FrameLoader::reloadAllowingStaleData is careful to only call setURL when there
is an unreachableURL, and I think that FrameLoader::reload should do the same. 
I suspect that it was not intentional to make FrameLoader::reload behave
differently in this respect.

Please see the attached patch for further details.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list