[Webkit-unassigned] [Bug 21883] [CAIRO] globalAlpha has to be stored and restored
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Oct 28 09:14:45 PDT 2008
https://bugs.webkit.org/show_bug.cgi?id=21883
vbs85 at gmx.de changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #24673|0 |1
is obsolete| |
Attachment #24717| |review?
Flag| |
------- Comment #4 from vbs85 at gmx.de 2008-10-28 09:14 PDT -------
Created an attachment (id=24717)
--> (https://bugs.webkit.org/attachment.cgi?id=24717&action=view)
save/restore globalAlpha
(In reply to comment #3)
> GraphicsContext already keeps a stack with internal state (see
> GraphicsContext.cpp GraphicsContext::save() and GraphicsContextPrivate.h). I
> was thinking it might be better to add an 'alpha' field to that and let
> GraphicsContext do the work for us so we don't need to maintain our own stack
> of alpha values for GraphicsContextCairo. Could you take a look into that?
I spoke to esedeidel via IRC as I implemented the current version of
globalAlpha. And he didn't like the idea to change GraphicsContextPrivate.h. A
globalAlpha variable is only needed on cairo and would waste space for other
platforms.
Or we use #if PLATFORM(CAIRO).
This second patch uses the alternative. Only One patch should be reviewed.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
More information about the webkit-unassigned
mailing list