[Webkit-unassigned] [Bug 21906] [Transforms] Double focus rings on text fields with transforms

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 27 15:36:24 PDT 2008


https://bugs.webkit.org/show_bug.cgi?id=21906





------- Comment #2 from simon.fraser at apple.com  2008-10-27 15:36 PDT -------
The problem is in RenderFlow::addFocusRingRects(), which has this code:

    if (!hasOverflowClip() && !hasControlClip()) {
        for (InlineRunBox* curr = firstLineBox(); curr; curr =
curr->nextLineBox())
            graphicsContext->addFocusRingRect(IntRect(tx + curr->xPos(), ty +
curr->yPos(), curr->width(), curr->height()));

        for (RenderObject* curr = firstChild(); curr; curr =
curr->nextSibling())
            if (!curr->isText() && !curr->isListMarker()) {
                int x = 0;
                int y = 0;
                if (curr->layer()) 
                    curr->absolutePosition(x, y);
                else {
                    x = tx + curr->xPos();
                    y = ty + curr->yPos();
                }
                curr->addFocusRingRects(graphicsContext, x, y);
            }
    }

It's using absolutePosition(), which does not respect transforms, so is adding
an additional, offset rect.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list