[Webkit-unassigned] [Bug 21638] WebCore/page/FrameTree.cpp:find() dispatches form submissions to incorrect frame

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 24 12:12:10 PDT 2008


sam at webkit.org changed:

           What    |Removed                     |Added
  Attachment #24391|review?                     |review-
               Flag|                            |

------- Comment #3 from sam at webkit.org  2008-10-24 12:12 PDT -------
(From update of attachment 24391)
> +	Frames now searched for by name starting at the innermost frame
> +	moving up the tree to the outermost containing parent level by level.
Please remove tabs.

> +    // Search up tree starting with this frame first.
> +    for (Frame* parent = m_thisFrame; parent; parent = parent->tree()->parent())
> +        for (Frame* frame = parent; frame; frame = frame->tree()->traverseNext(parent))
> +            if (frame->tree()->name() == name)
> +                return frame;
The two for-loops need braces.  I realize the old code didn't have them, but
they are required for all new code per our style guidelines.

r- due to the style issues.  Please also include a test with a LayoutTests
changelog in the same patch.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list