[Webkit-unassigned] [Bug 21850] New: svn-apply and svn-unapply should preserve patch line endings

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=21850

           Summary: svn-apply and svn-unapply should preserve patch line
                    endings
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Macintosh
        OS/Version: Mac OS X 10.5
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: ddkilzer at webkit.org
                CC: darin at apple.com, mrowe at apple.com, aroben at apple.com


* SUMMARY
When applying (or unapplying) a patch, svn-apply and svn-unapply will remove
all "native" line endings from a patch, and replace then with "\n".  This
causes problems when a patch contains more than one type of line ending (such
as changes to a *.vcproj file and a *.pbxproj file in the same patch).

* STEPS TO REPRODUCE
0. On a Mac OS X system.
1. Make changes to *.pbxproj and *.vcproj files.
2. Use svn-create-patch to create a patch of the changes.
3. Use svn-unapply to revert the changes using the patch file.

3a. Alternatively, use svn revert to back out the changes, then use svn-apply
with the patch file.

* RESULTS
The svn-unapply or svn-apply operation will fail because the "native" line
endings in the patch are currently stripped by the scripts.

* NOTES
Instead, both scripts should preserve the line endings for each patch, since
the patch(1) command knows how to deal with them anyway.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.