[Webkit-unassigned] [Bug 21842] New: custom constructors (like HTMLOptionElement) are not called during "new HTMLOptionElement"

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=21842

           Summary: custom constructors (like HTMLOptionElement) are not
                    called during "new HTMLOptionElement"
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Macintosh
        OS/Version: Mac OS X 10.5
            Status: NEW
          Keywords: Regression
          Severity: Normal
          Priority: P2
         Component: HTML DOM
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: eric at webkit.org
                CC: sam at webkit.org


custom constructors (like HTMLOptionElement) are not called during "new
HTMLOptionElement"

Why?

JSValuePtr jsDOMWindowHTMLOptionElementConstructor(ExecState* exec, const
Identifier&, const PropertySlot& slot)
{
    if
(!static_cast<JSDOMWindow*>(asObject(slot.slotBase()))->allowsAccessFrom(exec))
        return jsUndefined();
    return JSHTMLOptionElement::getConstructor(exec);
}

we call  JSHTMLOptionElement::getConstructor(exec), but JSHTMLOptionElement has
no custom implementation of getConstructor, because the idl doesn't have
GenerateConstructor defined.

Seems we need a CustomConstructor= idl flag.

I expect this is a regression, since otherwise I don't know why we'd have this
dead code in WebCore.  I'm not even really sure I understand what crazy
behavior the custom JSHTMLOptionElementConstructor is supposed to provide.

Tentatively marking this as a Regression.  Feel free to remove the flag if you
have more info to suggest it's not.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.