[Webkit-unassigned] [Bug 21816] Clean up ImageBuffer.h so there do not have to be separate ifdefs for each platform

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 23 15:41:47 PDT 2008


brettw at chromium.org changed:

           What    |Removed                     |Added
  Attachment #24624|                            |review?
               Flag|                            |

------- Comment #10 from brettw at chromium.org  2008-10-23 15:41 PDT -------
Created an attachment (id=24624)
 --> (https://bugs.webkit.org/attachment.cgi?id=24624&action=view)
Patch v2

This adds a flag to ImageBuffer that create can use to check if it should
return true or not. This has the nice effect of making create() cross-platform,
so I moved it into the header file. I think the platform-specific code is also
more clear as a result, you just have to set the flag properly and you don't
have to worry about writing create and returning an enpty auto_ptr.

I left IntSize passed by reference for consistency. I can still change all uses
of IntPoint in this class to by-value instead, but that seems less consistent
with the rest of the project to me.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list