[Webkit-unassigned] [Bug 21841] New: GraphicsContextCG uses CFURLRef conversions that may not be available

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=21841

           Summary: GraphicsContextCG uses CFURLRef conversions that may not
                    be available
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Macintosh
        OS/Version: Mac OS X 10.5
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Platform
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: mark at moxienet.com
                CC: eric at webkit.org
 BugsThisDependsOn: 21807


In WebCore/platform/graphics/cg/GraphicsContextCG.cpp,
GraphicsContext::setURLForRect takes a KURL argument and converts it to a
CFURLRef, to pass to CGPDFContextSetURLForRect.  This can only work when the
KURL-to-CFURLRef conversion is available in KURL.

In Chromium, we're using a different implementation of KURL, based on
GoogleURL, and ours doesn't do CFURLRef conversions.  We run into a problem,
then, when GraphicsContext::setURLForRect tries to do this conversion.  All
implementations of GraphicsContext other than the CG one just do
notImplemented() in setURLForRect.

The attached patch makes GraphicsContextCG sensitive to whether the GoogleURL
library is in use based on USE(GOOGLEURL), which was proposed in bug 21807. 
Because KURL support for CFURLRef conversions is also dependent on
PLATFORM(CF), I've included that for completeness.  If PLATFORM(CF) is not
defined or USE(GOOGLEURL) is, GraphicsContextCG::setURLForRect is a simple
notImplemented(), as it currently is on other platforms.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.