[Webkit-unassigned] [Bug 18703] changing the 'size' property on a text input does not affect its length

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=18703


gwilson at google.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24610|0                           |1
        is obsolete|                            |
  Attachment #24621|                            |review?
               Flag|                            |




------- Comment #12 from gwilson at google.com  2008-10-23 15:07 PDT -------
Created an attachment (id=24621)
 --> (https://bugs.webkit.org/attachment.cgi?id=24621&action=view)
Possible patch to bug 18703.

Ok, here's the modified patch with the suggested changes....it is probably much
simpler this way, so thanks for the feedback :)

I added the call that you specified, but I also had to add a check whether the
renderer was valid first.  I debated checking the type of the input element
too, but decided against it since non-text form input elements could also have
sizes that could be changed (the password type comes to mind.)  

I originally spotted 'idAttr' in Element, and thought size was also a valid DOM
attribute that could be tested, but I didn't realize it is HTML-specific. 
Sorry about that.

Thanks for the review!


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.