[Webkit-unassigned] [Bug 21839] SVGAnimatedTemplate needs HashMap.h included explicitly

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=21839


darin at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24616|review?                     |review+
               Flag|                            |




------- Comment #2 from darin at apple.com  2008-10-23 14:09 PDT -------
(From update of attachment 24616)
Change Log needs to have your name, not just dglazkov, in the header.

Also, you should remove the "WARNING: NO TEST CASES ADDED OR CHANGED" if you
don't need any tests and add a link to the bug.

It saves the committer time if you do those things right.

The reason this isn't needed for JSC platforms is that PlatformString.h
includes <kjs/identifier.h> which ends up including HashMap.h. To avoid making
ourselves crazy, we might just want to add a HashMap.h include to
PlatformString.h to eliminate this difference.

r=me, as is


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.