[Webkit-unassigned] [Bug 20430] DOMWindow is missing lots of SVG* constructor objects

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=20430


sam at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24572|review?                     |review-
               Flag|                            |




------- Comment #9 from sam at webkit.org  2008-10-23 11:37 PDT -------
(From update of attachment 24572)
> +        * svg/custom/global-constructors-expected.txt: Added.
> +        * svg/custom/global-constructors.html: Added.
You need to add the .js part of the test.


I think you should put this in its own patch as it is unrelated and needs its
own test.
> +++ b/WebCore/svg/SVGAnimateMotionElement.idl
> @@ -0,0 +1,31 @@
> +/*
> + * Copyright (C) 2006 Apple Computer, Inc.
This should have your copyright.


> +module svg {
> +
> +    interface [Conditional=SVG_ANIMATION] SVGAnimateMotionElement : SVGAnimationElement {
This needs GenerateConstructor.

> -    interface [Conditional=SVG, GenerateConstructor, ObjCProtocol] SVGZoomAndPan {
> +    interface [
> +        Conditional=SVG,
> +        GenerateConstructor,
> +        ObjCProtocol
> +    ] SVGZoomAndPan {
I don't think this should have a constructor, at least until we decide what to
do with pure interfaces.

Many additional classes need the GenerateConstructor extended attribute.  To
make your life easier, you may want to reverse it, and make it necessary to opt
out or a constructor.

r-  


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.