[Webkit-unassigned] [Bug 21826] Add accessor for SecurityOrigin::m_domainWasSetInDOM

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 23 10:20:51 PDT 2008


https://bugs.webkit.org/show_bug.cgi?id=21826


abarth at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |abarth at webkit.org
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




------- Comment #3 from abarth at webkit.org  2008-10-23 10:20 PDT -------
Fixed in http://trac.webkit.org/changeset/37814

> I am a little unclear about why this is necessary, the SecurityOrigin it self
> should be sufficient for a fast compare.  Perhaps we can remove this later.

Yeah, maybe there is a better long term solution here.  I think the fast path
for comparing SecurityOrigins in V8 gets inlined into the JITed code and they
want to avoid the function call overhead.  (I might be wrong about this, V8 is
pretty mysterious to me.)  It's similar to how JavaScriptCore doesn't bother
calling SecurityOrigin::canAccess if a frame is accessing itself (the most
common case) but taken to a little further extreme.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list