[Webkit-unassigned] [Bug 21724] Correct Build Regressions (Win32-Cairo)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=21724


aroben at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24478|review?                     |review+
               Flag|                            |




------- Comment #5 from aroben at apple.com  2008-10-22 10:11 PDT -------
(From update of attachment 24478)
 8         * WebCore.vcproj/WebCore.vcproj:  Correct paths for Cairo port.

I think it's helpful to say something along the lines of "Fixed include paths
and post-build event for the Debug_Cairo and Release_Cairo configurations and
added new Curl files."

 2  * Copyright (C) 2008 Collin Jackson  <collinj at webkit.org>

I don't think this copyright is needed (in DNSCurl.cpp).

 32 struct _CFURLRequest
 33 {
 34    int ignoreMe;
 35 };
 36 
 37 typedef const struct _CFURLRequest* CFURLRequestRef;

I think you can probably just do:

typedef const void* CFURLRequestRef;

Is there a reason why that won't work?

@@ HRESULT WebView::notifyPreferencesChange
41474147     hr = prefsPrivate->shouldPaintNativeControls(&enabled);
41484148     if (FAILED(hr))
41494149         return hr;
 4150 #if USE(SAFARI_THEME)
41504151     settings->setShouldPaintNativeControls(!!enabled);
 4152 #endif

Should we skip the prefsPrivate call when SAFARI_THEME is disabled, too?

r=me, even if you don't address the above.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.