[Webkit-unassigned] [Bug 16401] [GTK] GObject/C DOM binding

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=16401





------- Comment #85 from mrowe at apple.com  2008-10-17 14:42 PDT -------
(In reply to comment #50)
> --- WebCore/html/HTMLEmbedElement.idl   (revision 36459)
> +++ WebCore/html/HTMLEmbedElement.idl   (working copy)
> @@ -30,7 +30,7 @@
>          ImplementationUUID=93e0407a-8380-4ff0-978d-f773f2dee6a3
>      ] HTMLEmbedElement : HTMLElement {
>                   attribute [ConvertNullToNullString] DOMString align;
> -#if defined(LANGUAGE_JAVASCRIPT)
> +#if defined(LANGUAGE_JAVASCRIPT) || defined(LANGUAGE_GOBJECT)
>                   attribute [ConvertNullToNullString] DOMString height;
>  #else
>                   attribute [ConvertFromString] long height;
> @@ -38,7 +38,7 @@
>                   attribute [ConvertNullToNullString] DOMString name;
>                   attribute [ConvertNullToNullString] DOMString src;
>                   attribute [ConvertNullToNullString] DOMString type;
> -#if defined(LANGUAGE_JAVASCRIPT)
> +#if defined(LANGUAGE_JAVASCRIPT) || defined(LANGUAGE_GOBJECT)
>                   attribute [ConvertNullToNullString] DOMString width;
>  #else
>                   attribute [ConvertFromString] long width;
> 
> 
> 
> exact same functionality as javascript is required.  an int width
> and an int height is of absolutely no use.
> 
> pyjamas-desktop needs to be able to set width and height to what
> _javascript_ does - not objectiveC.
> 
> i.e. "100%".  "10em".  "20px".

The width and height properties of the DOM specification are defined as being
longs, so that is what they should be exposed to all bindings as.  JavaScript
is a special case as there is the requirement for compatibility with the
millions of real-world web pages that were coded to the initial implementations
of the DOM in browsers that did not adhere to the spec.

It's worth noting that setting the .width or .height properties of a
HTMLEmbedElement to "10em", "10en", or any other value followed by a CSS unit
is unlikely to do what you think.

> the integer-only parameters are no use to anyone wishing to maintain
> line-for-line javascript equivalent functionality, which is what
> pyjamas-desktop is about: ripping out the javascript and replacing it with
> exact-equivalent code, written in python instead of javascript.

That may be what your project is about, but it's not what DOM bindings in
WebKit are about.  DOM bindings are about exposing the standard WebKit DOM to
client applications, not about exposing JavaScript's somewhat warped
interpretation of the DOM.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.