[Webkit-unassigned] [Bug 21445] on windows, we try to remove m_smallCapsFontData from the font cache, but we never added it there

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=21445


hyatt at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24161|review?                     |review-
               Flag|                            |




------- Comment #4 from hyatt at apple.com  2008-10-07 14:30 PDT -------
(From update of attachment 24161)
You don't want to cache a custom font.  You only want to patch the
non-custom-font  code path.  Technically on Windows the small caps font won't
ever be shared, but for cross-platform consistency it's better to have that in
the cache even if it's pointless. :)

However I see an additional bug, namely that small caps font data in the custom
font path is leaking.  The SimpleFontData destructor is not deleting
m_smallCapsFontData in the custom font case.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.