[Webkit-unassigned] [Bug 21443] Allow HAVE_ACCESSIBILITY to be overridden at build time

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=21443





------- Comment #5 from amanda at chromium.org  2008-10-07 13:39 PDT -------
(In reply to comment #2)
That makes sense, though the purpose is to suppress the underlying capability
at build time.  I don't object to adding an ENABLE flag as well and requiring
both to be set, but it seems unnecessarily verbose at first glance (since it
would just change every occurrence of "HAVE(ACCESSIBILITY)" to
"HAVE(ACCESSIBILITY) && ENABLE(ACCESSIBILITY)".

Will fix tabs in changelog--oversight.

(In reply to comment #3)
> Moreover, the #if PLATFORM(MAC) && HAVE(ACCESSIBILITY) change doesn't make much
> sense. If you don't want accessibility in your port, you probably don't want to
> compile the Accessibility* classes in the first place. Can you try wrapping the
> entire classes with HAVE/ENABLE(ACCESSIBILITY) guards instead?

Great suggestion.  Will try that and upload a new patch.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.