[Webkit-unassigned] [Bug 20651] svgElement.className.baseValue does not work

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=20651


darin at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24124|review?                     |review+
               Flag|                            |




------- Comment #9 from darin at apple.com  2008-10-07 09:40 PDT -------
(From update of attachment 24124)
Can the test be changed into a dumpAsText test? I was able to do a number of
SVG tests that were portable that way.

+ if (attrName == HTMLNames::classAttr)

I'm surprised you chose to explicitly qualify here rather than doing using
namespace HTMLNames.

StyledElement::classAttributeChanged would be better if it only called
setChanged when there was an actual change. But that's not part of this fix, I
guess.

r=me


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.