[Webkit-unassigned] [Bug 20932] Notable leaks in QtWebkit - from Qt library

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=20932


hausmann at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24053|review?                     |review-
               Flag|                            |




------- Comment #10 from hausmann at webkit.org  2008-10-07 01:51 PDT -------
(From update of attachment 24053)
97     QWebView *webView() const {

Small coding style nitpick: Please use QWebView* webView()

389     WTF::Vector<QString*> m_urls;

QString is a value based class, you can simplify your code a lot and free it
from leaks by using WTF::Vector<QString> instead. Right now the QStrings
allocated in it are never freed.

In fact for the init() function I suggest the use of QString for the inputFile
argument and I also suggest the use of QFile and QTextStream instead of the C
file API. It will make your code simplier and more portable :)

r- for now, but in principle I agree with your patch and idea and I'd love to
see the patch go in :)


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.