[Webkit-unassigned] [Bug 17897] Not Rendering Images Imported from XHTML Document

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=17897





------- Comment #12 from jchaffraix at pleyo.com  2008-10-06 09:28 PDT -------
(In reply to comment #11)
> (From update of attachment 23215 [edit])
> > // our loader may have not fetched the image so do it now.
> 
> Should have a comma before "so do it now".

Sure.
> 
> > // If we do not have an image here, it means that an error
> > // occurred (cross-site violation...).
> 
> I don't understand the meaning of "..." in this comment.

I do not know all the possible errors that could occur here. I guess I could
just remove it.

>   class HTMLImageLoader : public CachedResourceClient {
> +
>   public:
> 
> Why are you adding a blank line here? We normally don't do that. The other
> blank line you added seems fine.

My bad, I got confused. It will be changed.

> I'm not sure the behavior here is right. If changing the URL triggers a new
> load, it's possible that re-setting the URL to the same value also should
> trigger a new load. We should test this in other browsers to be sure we match
> their behavior.
> 
> I'm going to say r=me because I think it's OK to land this patch as-is. But I'd
> really like to see us test that "does changing the URL to the same value
> trigger a load" question, because I think it may be needed to match the
> behavior of other web browsers.
> 

The patch has rotten and the HTMLImageLoader has been shared with SVG in the
ImageLoader so I will need to update it. I will try your use case and add the
required test case while updating it. Thanks!


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.