[Webkit-unassigned] [Bug 20760] Implement support for x86 Linux in CTI

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=20760





------- Comment #20 from barraclough at apple.com  2008-10-06 08:31 PDT -------
Generally, this looks great – reducing m_wrecFunction to a void* makes me a
little sad, but to be honest we'll probably end up turning it into a richer
type than a c function pointer anyway, so I don't think this is a problem.

One issue, it looks like you're defining CTI_ARGS in both CTI.h and Machine.h?
– if so, this is a little scary – we are likely going to make the set of
arguments more complex (so some values can be passed in registers), and if
these were to get out of sync this would be bad.  I'd prefer they were only
defined in CTI.h, but if this causes a circular dependency, then could CTI.h
include Machine.h? - exactly where we want this to be defined may shift as we
sort out the calling conventions, so I don't mind exactly where it ends up, but
would prefer if there is only one copy.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.