[Webkit-unassigned] [Bug 21338] New: IDL files use #if defined(ENABLE_whatever) instead of #if ENABLE(whatever)
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Oct 3 11:48:26 PDT 2008
https://bugs.webkit.org/show_bug.cgi?id=21338
Summary: IDL files use #if defined(ENABLE_whatever) instead of
#if ENABLE(whatever)
Product: WebKit
Version: 528+ (Nightly build)
Platform: All
OS/Version: All
Status: NEW
Severity: Normal
Priority: P2
Component: Platform
AssignedTo: webkit-unassigned at lists.webkit.org
ReportedBy: mark at moxienet.com
CC: eric at webkit.org
IDL files use #if defined(ENABLE_whatever) instead of #if ENABLE(whatever).
This is a problem now that JavaScriptCore/wtf/Platform.h provides definitions
for features that are supposed to be disabled, and features that are supposed
to be disabled are properly #defined to 0.
For example, in Chromium, we want WebKit database support off, and build with
-DENABLE_DATABASE=0, but files like WebCore/page/DOMWindow.idl check for:
#if defined(ENABLE_DATABASE)
Because ENABLE_DATABASE is #defined (although to 0), the preprocessor allows
the conditionalized section in. The check should be changed to:
#if ENABLE(DATABASE)
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
More information about the webkit-unassigned
mailing list