[Webkit-unassigned] [Bug 21333] New: Can't disable ENABLE_DASHBOARD or ENABLE_MAC_JAVA_BRIDGE on Mac

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=21333

           Summary: Can't disable ENABLE_DASHBOARD or ENABLE_MAC_JAVA_BRIDGE
                    on Mac
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Macintosh
        OS/Version: Mac OS X 10.5
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Platform
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: mark at moxienet.com
                CC: eric at webkit.org


JavaScriptCore/wtf/Platform.h defines a bunch of ENABLE_* macros, which turn
features on and off.  Most of these #defines are wrapped in #if !defined
blocks, which allows the Platform.h definitions to serve as defaults, but lets
external definitions override them.

In Chromium, we want to build with ENABLE_DASHBOARD=0, but this is not possible
on the Mac because Platform.h does:

#if PLATFORM(MAC)
#define ENABLE_DASHBOARD 1
#endif

This results in a macro redefinition and is not what we want.  I propose
wrapping the ENABLE_DASHBOARD and ENABLE_MAC_JAVA_BRIDGE macros in #if !defined
blocks like all other ENABLE_ macros in Platform.h.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.