[Webkit-unassigned] [Bug 20625] ConsoleMessage should have a "type" attribute

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=20625


timothy at hatcher.name changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #23938|review?                     |review-
               Flag|                            |




------- Comment #2 from timothy at hatcher.name  2008-10-02 12:17 PDT -------
(From update of attachment 23938)
This needs some updates to work with TOT.


             // This _format call passes in true for the plainText argument.
The result's textContent is
             // used for inline message bubbles in SourceFrames, or other
plain-text representations.
-            this.message = this._format(Array.prototype.slice.call(arguments,
6), true).textContent;
+            this.message = this._format(Array.prototype.slice.call(arguments,
7), true).textContent;

             // The formatedMessage property is used for the rich and
interactive console.
-            this.formattedMessage =
this._format(Array.prototype.slice.call(arguments, 6));
+            this.formattedMessage =
this._format(Array.prototype.slice.call(arguments, 7));
             break;

We no longer call _format twice.

Otherwise looks good! But r- until it can apply to TOT,


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.