[Webkit-unassigned] [Bug 22564] Make HTML elements' constructors take a QualifiedName
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Nov 30 14:23:52 PST 2008
https://bugs.webkit.org/show_bug.cgi?id=22564
eric at webkit.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #25609|review? |review+
Flag| |
------- Comment #2 from eric at webkit.org 2008-11-30 14:23 PDT -------
(From update of attachment 25609)
I find this pattern a bit strange:
if (!MediaPlayer::isAvailable())
return new HTMLElement(tagName, doc);
- return new HTMLVideoElement(doc);
+ return new HTMLVideoElement(videoTag, doc);
As antti pointed out before, that will break any uses of if
(element->hasTagName(videoTag) static_cast<HTMLVideoElement*>(element)...
Agreed, we should always be using something like element->isVideoElement()
instead.
The patch looks fine.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
More information about the webkit-unassigned
mailing list