[Webkit-unassigned] [Bug 21638] WebCore/page/FrameTree.cpp:find() dispatches form submissions to incorrect frame

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=21638


ddkilzer at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24681|review?                     |review-
               Flag|                            |




------- Comment #6 from ddkilzer at webkit.org  2008-11-29 21:40 PDT -------
(From update of attachment 24681)
>+2008-10-26  John Holdsworth  <webkit at johnholdsworth.com>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Frames now searched for by name starting at the innermost frame
>+        moving up the tree to the outermost containing parent level by level.
>+
>+        * fast/frames/frameTree-form.html: Added.
>+        * fast/frames/frameTree-frame.html: Added.
>+        * fast/frames/frameTree-top.html: Added.

This is a good first step toward a layout test, John!  However, please note
that:

- Layout tests are run in an automated fashion.
- The patch should include the expected results of the tests (see
WebKitTools/Scripts/run-webkit-tests --help).
- Layout tests should not depend on external resources (like www.google.com).

Please see this page for more details:

http://webkit.org/quality/testwriting.html

The easiest thing to do is to look at a similar test when writing your own.

Note that since this is a form submission issue, you may need to write an
"http" test (see LayoutTest/http/tests/) which run under an Apache web server.

r- to fix layout test issues.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.