[Webkit-unassigned] [Bug 22553] Remove unneeded GObject casts.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=22553


zecke at selfish.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #25594|review?                     |review+
               Flag|                            |




------- Comment #2 from zecke at selfish.org  2008-11-29 19:44 PDT -------
(From update of attachment 25594)
> From 986ed09d38f02e5a51fd5b9834cafe06e7e272e1 Mon Sep 17 00:00:00 2001
> From: Xan Lopez <xan at gnome.org>
> Date: Sat, 29 Nov 2008 14:09:59 +0200
> Subject: [PATCH] Remove unneeded GObject casts.
> 
> ---
>  WebKit/gtk/ChangeLog                             |   28 ++++++++++++++++++++++
>  WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp    |   22 ++++++++--------
>  WebKit/gtk/WebCoreSupport/InspectorClientGtk.cpp |    4 +-
>  WebKit/gtk/webkit/webkitwebframe.cpp             |    6 ++--
>  WebKit/gtk/webkit/webkitwebview.cpp              |    4 +-
>  WebKit/gtk/webkit/webkitwebwindowfeatures.cpp    |   10 ++++----
>  6 files changed, 51 insertions(+), 23 deletions(-)
> 
> diff --git a/WebKit/gtk/ChangeLog b/WebKit/gtk/ChangeLog
> index 57a6479..62e35b6 100644
> --- a/WebKit/gtk/ChangeLog
> +++ b/WebKit/gtk/ChangeLog
> @@ -1,3 +1,31 @@
> +2008-11-29  Xan Lopez  <xan at gnome.org>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +	https://bugs.webkit.org/show_bug.cgi?id=22553

indention wrong? mixing tabs and spaces?

besides that, you are right, g_object_set, g_object_ref, g_object_unref take a
plain gpointer and there is no need to cast it.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.