[Webkit-unassigned] [Bug 22560] PATCH: Some Gtk Screen functions assume widgets are realized, leading to segfaults.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=22560





------- Comment #2 from zecke at selfish.org  2008-11-29 19:41 PDT -------
(From update of attachment 25603)

> -    GdkVisual* visual = gdk_drawable_get_visual(GDK_DRAWABLE(GTK_WIDGET(widget->root()->hostWindow()->platformWindow())->window));
> +	if (!GTK_WIDGET_REALIZED(container))
> +	{
> +		GtkWidget * toplevel = gtk_widget_get_toplevel(container);
> +		if (GTK_WIDGET_TOPLEVEL(toplevel))
> +			container = toplevel;
> +		else
> +			return 24;
> +	}

please see the WebKit.org CodingStyle guideleines. the '{' is on the wrong
line, your indention is messed up, also the indention of the ChangeLog is
messed. Please fix this and attach an updated version of the patch.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.