[Webkit-unassigned] [Bug 20340] SegmentedVector segment allocations can lead to unsafe use of temporary registers

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=20340


cwzwarich at uwaterloo.ca changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|webkit-                     |cwzwarich at uwaterloo.ca
                   |unassigned at lists.webkit.org |




------- Comment #11 from cwzwarich at uwaterloo.ca  2008-11-29 00:37 PDT -------
I am reassigning this to myself to match Radar. There are only two forms of
resizing currently done for a SegmentedVector:

- the BytecodeGenerator reserves capacity for m_globals and m_parameters. We
can just add a reserveCapacity() method to SegmentedVector. As a side note,
this latter one should really be a Vector with a smaller capacity, as we do not
pass out any parameter registers before we know the number of parameters.

- the Lexer now shrinks its identifier SegmentedVector to 0 in Lexer::clear().
We don't need to handle arbitrary shrinkage, so a clear() method makes more
sense.

I will remove resize() as a public method and add these two in one patch, then
in a followup patch I will actually make the change that causes SegmentedVector
to never shrink, which should actually be fairly easy.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
You are the assignee for the bug, or are watching the assignee.