[Webkit-unassigned] [Bug 22528] Move currentThreadStackBase() to WTF

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=22528





------- Comment #3 from alp at nuanti.com  2008-11-28 06:42 PDT -------
(In reply to comment #2)
> > -static inline void* currentThreadStackBase()
> 
> I'm wondering why this function was inline.
> 

I added CollectorUtilities.cpp to AllInOneFile.cpp just above Collector.cpp,
guessing gcc will inline it if appropriate at -O3. If you're concerned it might
affect performance, could you try running a perf test with this patch applied?
I don't think inlining or not will affect the correctness of the result (this
function is for finding the stack base, not stack pointer so it's fine as a
function call).


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.