[Webkit-unassigned] [Bug 22524] XMLHttpRequest needs to have the static defines made threadsafe.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 27 23:13:35 PST 2008


levin at chromium.org changed:

           What    |Removed                     |Added
  Attachment #25555|review?                     |
               Flag|                            |
  Attachment #25555|0                           |1
        is obsolete|                            |
  Attachment #25566|                            |review?
               Flag|                            |

------- Comment #4 from levin at chromium.org  2008-11-27 23:13 PDT -------
Created an attachment (id=25566)
 --> (https://bugs.webkit.org/attachment.cgi?id=25566&action=view)
Changed the static initialization to happen in the XHR constructor.

I didn't like doing a mutex in the functions due to one of them being called
inside of a loop.   As discussed, I've tried out a solution that initializes
the static variables in the constructor.  I looked at a few ways of doing this.
 The reason I put the variables in a struct and then initialized into a local
static was to take advantage of AtomicallyInitializedStatic.

If this doesn't seem that great, one alternative I can think of is to create
another macro like AtomicallyInitializedStatic (in threading.h) that allowed me
to call a function inside of this same mutex.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list