[Webkit-unassigned] [Bug 22518] New: Element subclasses need only pass an optional prefix in their constructor
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Nov 26 16:08:52 PST 2008
https://bugs.webkit.org/show_bug.cgi?id=22518
Summary: Element subclasses need only pass an optional prefix in
their constructor
Product: WebKit
Version: 528+ (Nightly build)
Platform: Macintosh
OS/Version: Mac OS X 10.5
Status: NEW
Severity: Normal
Priority: P2
Component: New Bugs
AssignedTo: webkit-unassigned at lists.webkit.org
ReportedBy: eric at webkit.org
CC: koivisto at iki.fi, jchaffraix at pleyo.com
HTMLElement subclasses need only pass an optional prefix in their constructor
The same applies to SVGElement subclasses too. Currently the constructor
signature for most classes is:
SVGSVGElement(const QualifiedName&, Document*);
HTMLHtmlElement(const QualifiedName&, Document*);
But they really should be more like:
SVGSVGElement(Document*, AtomicString prefix = nullAtom);
HTMLHtmlElement(Document*, , AtomicString prefix = nullAtom);
non-leafnode Element subclasses will still require a full Qualified Name (At
least a localname and prefix pair).
I'm personally ambivalent as to if the tradeoff changing from QualifiedName to
AtomicString is worth it (Since i will make the method signatures for all
Element subclasses less uniform. But others in the project feel stronger about
it, and so I'm filing this bug for proper discussion and eventual code change.)
:)
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
More information about the webkit-unassigned
mailing list