[Webkit-unassigned] [Bug 22070] Add an option to allow scripts to close windows.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=22070


sam at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #25513|review?                     |review-
               Flag|                            |




------- Comment #4 from sam at webkit.org  2008-11-25 19:44 PDT -------
(From update of attachment 25513)
> +    bool allowScriptsToCloseWindows =
> +        (settings && settings->allowScriptsToCloseWindows());
No reason to put these on two lines.

> @@ -232,6 +235,7 @@ namespace WebCore {
>          bool m_zoomsTextOnly : 1;
>          bool m_enforceCSSMIMETypeInStrictMode : 1;
>          size_t m_maximumDecodedImageSize;
> +        bool m_allowScriptsToCloseWindows : 1;
If you move this bool up one place, it will not cause unnessary bloating of the
object.

This patch looks fine, but it is not hooked up to anything.  Usually when we
expose a new setting, we hook it up to the WebPreferences API (or probably SPI
in this case) in WebKit.  r- since this really won't do anything on its own.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.