[Webkit-unassigned] [Bug 22468] Coding style: config.h should only be included in implementation files, not in header

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=22468


eric at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #25509|review?                     |review-
               Flag|                            |




------- Comment #2 from eric at webkit.org  2008-11-25 17:49 PDT -------
(From update of attachment 25509)
I'm not sure it's clear to me from reading what an "implementation" file is. 
Maybe (.cpp, .c, .mm, etc.) as an aside would help.

This sentence is backwards:
This guarantees that each header's completeness is tested,
+to make sure it can be compiled without requiring any other header files be
+included first.

"This assures that each header can be compiled without requiring any other
header included first."  or similar, no need to state "completeness" and then
define it.

An extra wrong example of HTMLDivElement.h might be helpful.

Having HTMLDivElement.cpp unsorted might also be useful. :)

Otherwise looks fine.  This is a useful change to the style guide.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.