[Webkit-unassigned] [Bug 18830] Assertion failure (using HashMap empty value) in svg/W3C-SVG-1.1/fonts-glyph-02-t.svg

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=18830


eric at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #25224|review?                     |review-
               Flag|                            |




------- Comment #9 from eric at webkit.org  2008-11-25 17:44 PDT -------
(From update of attachment 25224)
I don't understand this change.  Maybe mitz would.  It looks right, but I think
we could make this clearer using some local variable with clearer names.  Why
does all this need to be manual calculation?  Don't we have TextIterators or
similar for this kind of thing?

Here I'm going to be a hypocrit and mention there is not ChangeLog in this
patch.  :(  I know how much ChangeLogs suck with git... 

My approach here would be to start by cleaning up the code to the point where I
understood what it was doing... and then I would fix the bug.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.