[Webkit-unassigned] [Bug 22441] Bridge the gap between the generated ElementFactory and HTMLElementFactory

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 25 16:07:01 PST 2008


https://bugs.webkit.org/show_bug.cgi?id=22441


jchaffraix at pleyo.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |eric at webkit.org




------- Comment #16 from jchaffraix at pleyo.com  2008-11-25 16:07 PDT -------
(In reply to comment #15)
> (From update of attachment 25506 [review])
> To clarify, if you were to fix the bug:
> 
> static PassRefPtr<HTMLElement> htmlConstructor(const QualifiedName&, Document*
> doc, HTMLFormElement*, bool)
> 9797 {
> 98      return new HTMLHtmlElement(doc);
>  98     return new HTMLHtmlElement(htmlTag, doc);
> 
> you would give the qName argument a name, and pass it through, instead of using
> htmlTag there.
> 

Yes, there is a comment about that in Document::createElement. It would be good
to solve it but it is not the purpose of this bug so I will stick to been
simple in the fixes until the ElementFactory have been all been merged. As a
side note, I am not sure the ElementFactory would survive this change for the
moment.
Thanks for the review and the reminder.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list