[Webkit-unassigned] [Bug 22478] Incorrect timer firing in caret blinking.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 25 11:31:56 PST 2008


eric at webkit.org changed:

           What    |Removed                     |Added
  Attachment #25472|review?                     |review-
               Flag|                            |

------- Comment #2 from eric at webkit.org  2008-11-25 11:31 PDT -------
(From update of attachment 25472)
I'm not sure why you're renaming the method.  Doesn't really matter to me so
long as all callers and implementers were successfully renamed.

Tabs in your changelog:
+                               Renamed caretBlinkFrequency to

The description in the bug was much nicer than the one in the Changelog,
perhaps you write something similar in the ChangeLog itself, and make sure to
reference this bug number in the ChangeLog.

WebKit Style:
has no { } around single-line ifs:
+        if (float blinkInterval = theme()->caretBlinkInterval()) {
+            d->m_caretBlinkTimer.startRepeating(blinkInterval);
+        }

Thanks for the patch.  It's hard for me to tell if this is right or not.  Is it
possible to have a non-blinking caret on Windows as well?  Will that cause a
"blink/timer storm" like the Gtk setting will?

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list