[Webkit-unassigned] [Bug 22443] XMLHttpRequest's PreflightResultCache should be thread-safe.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=22443


ap at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #25485|review?(ap at webkit.org)      |review+
               Flag|                            |




------- Comment #14 from ap at webkit.org  2008-11-25 10:58 PDT -------
(From update of attachment 25485)
> +2008-11-25  David Levin  <set EMAIL_ADDRESS environment variable>

Please do. Also, please reference this bug in ChangeLog, so that anyone reading
it could easily find the relevant discussions.

> +    bool parse(const ResourceResponse& response);

The argument name should be omitted, because it doesn't add anything that its
type doesn't say (same elsewhere).

> +class PreflightResultCache : public Noncopyable {

We currently use private inheritance for Noncopyable, although it doesn't
really matter.

r=me. I'll address my own comments while landing this patch.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.