[Webkit-unassigned] [Bug 22480] We should cache get by id chain accesses polymorphically.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 24 23:19:31 PST 2008


barraclough at apple.com changed:

           What    |Removed                     |Added
         AssignedTo|webkit-                     |barraclough at apple.com
                   |unassigned at lists.webkit.org |
             Status|NEW                         |ASSIGNED
  Attachment #25475|                            |review?
               Flag|                            |

------- Comment #1 from barraclough at apple.com  2008-11-24 23:19 PDT -------
Created an attachment (id=25475)
 --> (https://bugs.webkit.org/attachment.cgi?id=25475&action=view)
The patch

        Polymorpic caching for get by id chain.  Similar to the polymorphic
caching already implemented
        for self and proto accesses (implemented by allowing multiple
trampolines to be JIT genertaed,
        and linked together) - the get by id chain caching is implemented as a
genericization of the
        proto list caching, allowing cached access lists to contain a mix of
proto and proto chain
        accesses (since in JS style inheritance hierarchies you may commonly
see a mix of properties
        being overridden on the direct prototype, or higher up its prototype

        In order to allow this patch to compile there is a fix to appease gcc
4.2 compiler issues
        (removing the jumps between fall-through cases in privateExecute).

        This patch also removes redundant immediate checking from the reptach
code, and fixes a related
        memory leak (failure to deallocate trampolines). 

        ~2% progression on v8 tests (bulk on the win on deltablue)

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list