[Webkit-unassigned] [Bug 22441] Bridge the gap between the generated ElementFactory and HTMLElementFactory

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=22441





------- Comment #11 from jchaffraix at pleyo.com  2008-11-24 15:34 PDT -------
(In reply to comment #10)
> (From update of attachment 25453 [review])
> > -        WebCore::Element* createElement(const WebCore::QualifiedName& qName, WebCore::Document* doc, bool createdByParser = true);
> > -        static $parameters{'namespace'}Element* create$parameters{'namespace'}Element(const WebCore::QualifiedName& qName, WebCore::Document* doc, bool createdByParser = true);
> > +        PassRefPtr<Element> createElement(const WebCore::QualifiedName&, WebCore::Document*, bool createdByParser = true);
> > +        static PassRefPtr<$parameters{'namespace'}Element> create$parameters{'namespace'}Element(const WebCore::QualifiedName&, WebCore::Document*, bool createdByParser = true);
> 
> I don't understand how you can change the declaration of the createElement
> function here without also changing the return type in the definition of
> createElement. I guess that's just a placeholder for the future.

FYI, createElement is never implemented and is indeed a placeholder related to
a comment in make_names.pl
(http://trac.webkit.org/browser/trunk/WebCore/dom/make_names.pl#L633). I have
weighted about removing it from both make_names.pl and HTMLElementFactory but I
liked the idea of leaving this FIXME.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.