[Webkit-unassigned] [Bug 22441] Bridge the gap between the generated ElementFactory and HTMLElementFactory

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=22441


darin at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #25404|review?                     |review-
               Flag|                            |




------- Comment #4 from darin at apple.com  2008-11-23 19:12 PDT -------
(From update of attachment 25404)
> +typedef PassRefPtr<$parameters{'namespace'}Element> (*ConstructorFunc)(Document* doc, bool createdByParser);

There should not be a space between the ">" and the "(" symbols.

(These issues already existed.) The Document* argument should not have the name
"doc" -- the name should just be omitted. And the type should be named
ConstructorFunction, not ConstructorFunc. There's no value in abbreviating the
type name.

> +#include "config.h"

Headers should not include the "config.h" header; that's to be included by cpp
files only.

> +#ifndef $parameters{'namespace'}ElementFactory_h
> +#define $parameters{'namespace'}ElementFactory_h

The #ifndef part should go before the includes, not after them.

>      class $parameters{'namespace'}ElementFactory
>      {

(This issue already existed.) The brace should be on the same line as the class
name.

>      public:
> -        WebCore::Element* createElement(const WebCore::QualifiedName& qName, WebCore::Document* doc, bool createdByParser = true);
> -        static $parameters{'namespace'}Element* create$parameters{'namespace'}Element(const WebCore::QualifiedName& qName, WebCore::Document* doc, bool createdByParser = true);
> +        PassRefPtr<Element> createElement(const WebCore::QualifiedName& qName, WebCore::Document* doc, bool createdByParser = true);
> +        static PassRefPtr<$parameters{'namespace'}Element> create$parameters{'namespace'}Element(const WebCore::QualifiedName& qName, WebCore::Document* doc, bool createdByParser = true);

(This issue already existed.) The argument names qName and doc should be
omitted.

I don't see the change to the createElement definition.

review- because of the "cofig.h" issue


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.