[Webkit-unassigned] [Bug 22300] Use of NSCalibratedRGBColorSpace for CSS system colors causes layout tests to fail due to screen calibration

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 20 19:00:08 PST 2008


https://bugs.webkit.org/show_bug.cgi?id=22300


pol at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #25329|                            |review?
               Flag|                            |




------- Comment #5 from pol at apple.com  2008-11-20 19:00 PDT -------
Created an attachment (id=25329)
 --> (https://bugs.webkit.org/attachment.cgi?id=25329&action=view)
Patch v1

The way to fix this issue and other potential ones is to ensure WebKit is
always using Device RGB colorspace internally, which is mostly the case today.

Note that I replaced calls to +[NSColor whiteColor] as well since these return
colors in calibrated colorspace.

I ran all layout tests with pixel tests enabled and disabled and no regressions
were reported, except for
platform/mac/fast/text/attributed-substring-from-range-001.html which needs to
be updated.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list