[Webkit-unassigned] [Bug 22215] Avoid calling absoluteClippedOverflowRect() so many times

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=22215





------- Comment #3 from darin at apple.com  2008-11-20 14:06 PDT -------
(From update of attachment 25113)
Comments on the patch, even though it's been withdrawn from review.

> +    // Repaint only if our old bounds and new bounds are different. bounds and outlineBox may be passed if known.
> +    bool repaintAfterLayoutIfNeeded(const IntRect& oldBounds, const IntRect& oldOutlineBox, IntRect* bounds = 0, IntRect* outlineBox = 0);

These should be "const IntRect*", since the recipient is being asked not to
modify them.

> -        repaintAfterLayoutIfNeeded(oldBounds, oldOutlineBox);
> +        repaintAfterLayoutIfNeeded(oldBounds, oldOutlineBox);   // can we pass m_absoluteBounds?

I think this comment is a little too cryptic to check in: Who's asking the
question and who would answer it? You could write a less cryptic comment,
perhaps one that is a little more specific about why you're uncertain and what
the benefit of passing it in would be. Maybe you can just leave it out for now.
If you did want it in there, you should use our standard formatting, and use
only one space before the command and capitalize the first word in the
sentence.

> +        repaintAfterLayoutIfNeeded(oldBounds, oldOutlineBox);       // can we pass m_absoluteBounds?

Ditto.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.