[Webkit-unassigned] [Bug 22328] Worker object should implement WindowTimers interface as per HTML5 spec

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 20 03:34:39 PST 2008


https://bugs.webkit.org/show_bug.cgi?id=22328


ap at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #25304|review?(ap at webkit.org)      |
               Flag|                            |




------- Comment #3 from ap at webkit.org  2008-11-20 03:34 PDT -------
(From update of attachment 25304)
Aside from code style issues, I have two comments. First, DOMTimer inherits
from TimerBase, which is not thread safe, and doesn't work in non-main threads
anyway (on Mac OS X, it uses CFRunLoopTimerCreate on main run loop). Second,
clearAllTimeouts and related functions need to be modified to take advantage of
DOMTimer being an ActiveDOMObject. Pausing and resuming timers will probably
require support for pausing/resuming active DOM objects, which is needed
anyway.

You may want to discuss this with someone who actually knows how timers used to
work though!


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list