[Webkit-unassigned] [Bug 22350] Allow layout tests to run in php cgi mode

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 19 20:07:22 PST 2008


------- Comment #5 from deanm at chromium.org  2008-11-19 20:07 PDT -------
I realize it would much better if everyone ran Apache.  We have a bit of a
complicated setup, and we have tried very hard to make our checkout hermetic. 
Because of this, we have a little hermetic cygwin, etc.  Long story short, we
were having lots of problems with Apache deadlocking in our configuration, and
moving to lighttpd has made everything much better.  Originally it was just to
fix the Apache on Windows issues, but now I think lighttpd is much simpler
overall for all of our platforms.

Now background aside, I think this PHP change makes sense anyway.  The $_SERVER
variable should be preferred over getallheaders().  Lots of PHP code is written
this way, and it supports both configurations of mod_php and CGI.  It also
makes the code significantly simpler, as you can just dictionary address and
get the header you're interested in.

Let me know if you think there are any issues with the patch.  The fact we're
using lighttpd is something we're not going to be able to change for now.

-- dean

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list