[Webkit-unassigned] [Bug 20393] Add WML support to WebKit

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=20393





------- Comment #39 from yichao.yin at torchmobile.com.cn  2008-11-17 19:33 PDT -------
(In reply to comment #37)
> (In reply to comment #35)
> > (In reply to comment #34)
> > > Hi Yichao,
> > > I'm working on a whole new revision of this patch, actually working in non-Qt
> > > environments, most noticeable: Mac/Cocoa. WMLTokenizer is tied to Qt at the
> > > moment, I'll fix that.
> > 
> > * Thanks zimmermann! Yes, what I submitted this time is just for Qt. Actually,
> > For Mac, we are using libxml2 to parse the WML document. The related code is in
> > XMLTokenizerLibxml2.cpp. Because I have no the Mac envrionment, George has ever
> > planned to verify the code. But I guess he is too busy to do that. Anyway, I
> > will upload the patch to bugzilla for your reivew later.
> > 
> > > > * Yes, we'd better set value of class member with setXXXX() method by
> > > > convetion.
> > > > In some cases WMLSelectElement needs to update the
> > > > HTMLSelectElement::m_multiple but HTMLSelectElement::setMultiple() doesn't
> > > > support it. I think we needn't to add new method for HTMLSelectElement and
> > > > WMLSelectElement to implement that. 
> > > > Of cource, you are right. we should  not affect HTML while WML is enabled. I
> > > > have fixed it in my new patch.
> > > I think you don't need to change setMultiple in any way, because the
> > > setAttribute() call will immediately call parseMappedAttribute, which takes
> > > care of setting m_multiple to the correct value.
> > 
> > * You are right. But WMLSelectElement::parseMappedAttribute can't update the
> > m_multiple directly because it is private. thus we have to make m_multiple
> > protected or let HTMLSelectElement class to offer new method setXXXX to let its
> > subclass to set m_multiple. Obviously, the latter is better. but it't not easy
> > to name the new method properly, you know, setMultiple() exists and it's
> > supposed to be used to update the m_multiple member of HTMLSelectElement class
> > in general. That's why I decide to hack it in HTMLSelectElement::setMultple()
> > for WMLSelectElement. How do you think about it?
> Hi Yichao,
> as we discussed in private mails, the idea is that WMLSelectElement doesn't
> inherit from HTMLSelectElement at all, but instead we should have a common
> SelectElement base-class for both of them. That'll resolve all these problems,
> patch upcoming soon.
> Greetings,
> Niko

Hi Niko,
Yes, this problem won't appear for the new design any more.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.