[Webkit-unassigned] [Bug 22299] Improve visual studio 2008 sp1 compilation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=22299


eric at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #25203|review?                     |review-
               Flag|                            |




------- Comment #3 from eric at webkit.org  2008-11-17 13:29 PDT -------
(From update of attachment 25203)
You should set CHANGE_LOG_NAME or REAL_NAME to "Marc-Antoine Ruel" (or just
edit the ChangeLog after the fact to have your real name instead of maruel).

Why add _ to the end of these template parameter names?  That's not WebKit
style, it might be google style, I'm not even sure of that (but that doesn't
really have any bearing here).

Also generally we mention the bug number in the changelog, and it would be nice
for documentations sake to have the text of the warning/error in the bug or the
changelog.  Maciej or Darin (Adler) would be most likely to review this change,
as they're the two template experts in the WebKit community (that I know of).

r- for the reasons mentioned above.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.