[Webkit-unassigned] [Bug 22056] Share FrameLoaderClient::transitionToCommittedForNewPage between Win/Gtk+/Qt

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=22056


hausmann at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24870|review?                     |review+
               Flag|                            |




------- Comment #9 from hausmann at webkit.org  2008-11-17 07:53 PDT -------
(From update of attachment 24870)
Nice cleanup!

> +    FrameView* frameView;
> +    if (isMainFrame) {
> +        frameView = new FrameView(frame, size);
> +    } else

Minor coding style issue with the braces there.
r+ and please fix the braces when landing :)


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.