[Webkit-unassigned] [Bug 22240] Add ifdef around toJS function in Plugin.h

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=22240


darin at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #25139|review?                     |review-
               Flag|                            |




------- Comment #2 from darin at apple.com  2008-11-13 16:26 PDT -------
(From update of attachment 25139)
> Index: WebCore/ChangeLog
> ===================================================================
> --- WebCore/ChangeLog	(revision 38377)
> +++ WebCore/ChangeLog	(working copy)
> @@ -1,3 +1,11 @@
> +2008-11-13  jabdelmalek  <set EMAIL_ADDRESS environment variable>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        WARNING: NO TEST CASES ADDED OR CHANGED
> +
> +        * plugins/Plugin.h:

This is not a sufficient ChangeLog. You need to put your name in, your email
address, remove the "WARNING" message since this doesn't need test cases, add
the URL of the bug you're fixing, and add a comment explaining the change
you're making.

The code change is great. I'm going to say review- since it should be easy for
you to make a good ChangeLog and re-post the patch with that included.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.