[Webkit-unassigned] [Bug 21261] Add layoutTestController API so that animation layout tests don't have to delay

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=21261


sam at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #25125|review?                     |review+
               Flag|                            |




------- Comment #8 from sam at webkit.org  2008-11-13 11:45 PDT -------
(From update of attachment 25125)
  > +- (BOOL)_pauseAnimation:(NSString*)name onNode:(DOMNode *)node
atTime:(NSTimeInterval)time
> +{
> +    WebCore::Frame *frame = core(self);
> +    if (!frame)
> +        return false;
> +
> +    AnimationController* controller = frame->animation();
> +    if (!controller)
> +        return false;
> +
> +    WebCore::Node *coreNode = [node _node];
> +    if (!coreNode || !coreNode->renderer())
> +        return false;
> +
> +    return controller->pauseAnimationAtTime(coreNode->renderer(), name, time);
The * should be on the other side for c++ types like Node and Frame.  You also
are inconsistent with prefixing WebCore types with WebCore::, if it is not
necessary, we shouldn't use it anywhere.

> +- (BOOL)_pauseTransitionOfProperty:(NSString*)name onNode:(DOMNode*)node atTime:(NSTimeInterval)time
> +{
> +    WebCore::Frame *frame = core(self);
> +    if (!frame)
> +        return false;
> +
> +    AnimationController* controller = frame->animation();
> +    if (!controller)
> +        return false;
> +
> +    WebCore::Node *coreNode = [node _node];
> +    if (!coreNode || !coreNode->renderer())
> +        return false;
> +
> +    return controller->pauseTransitionAtTime(coreNode->renderer(), name, time);

Same here.

> +bool LayoutTestController::pauseAnimationAtTimeOnElementWithId(JSStringRef animationName, double time, JSStringRef elementId)
> +{
> +    return false; // FIXME: Implement this on Windows
> +}
> +
> +bool LayoutTestController::pauseTransitionAtTimeOnElementWithId(JSStringRef propertyName, double time, JSStringRef elementId)
> +{
> +    return false; // FIXME: Implement this on Windows
> +}

You probably need to either put the new tests on the Windows skipped list or
add Windows specific results.  You should also file a bug about implementing
the Windows version.

r=me. 


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.